Toolbars for iOS apps' MainWindows.#4048
Conversation
3fd4ebe to
58584a9
Compare
freakboy3742
left a comment
There was a problem hiding this comment.
Whenever I'm reviewing a PR, my first question is "How do I test this?". I can confirm that the Command example does work; but with a few weird glitches - which possibly fall inside the boundaries of the platform notes you've documented
But that's pointing at the bigger issue here - you've implemented a bunch of logic, making a bunch of design decisions, without actually confirming if those design decisions are appropriate or acceptable. The fact that you've got a multiple paragraphs of platform notes, and no other platform requires those notes should be an indicator of something.
This is a non-trivial body of work, being where there isn't a straightforward "implement the same API on a new platform". The first step is to propose a course of action, not implement it. An implementation could be a useful proof of concept - but only if that's the easiest path to illustrate the proposal.
So - in this case, I suggest stepping back a bit and at least documenting the concerns here so we can have a conversation about the design decisions you've made.
Adds toolbar support to iOS MainWindows.
All caveats and user cautions documented inline.
PR Checklist: